Deactivate Requests to External ROR API #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests to this external API are used for fetching organisations that may not already exist within the local db. At this time, DMP Assistant is limiting organisations to only those that exist within the local db. (New organisations are currently only created manually by DMP super admins).
In order to be executed successfully, the RSpec tests within spec/services/external_apis/ror_service_spec.rb require that Rails.configuration.x.ror.active = true. Regardless of the value of this variable within config/initializers/external_apis/ror.rb, this commit overrides the value to true for the duration of the spec/services/external_apis/ror_service_spec.rb tests.
aaronskiba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Deactivate External Requests to ROR API
https://api.ror.org/are used for fetching organisations that may not already exist within the local db. At this time, DMP Assistant is limiting organisations to only those that exist within the local db. (New organisations are currently only created manually by DMP super admins).Rails.configuration.x.ror.active = falseas we did here should limit searching to only the local db (to verify this handling, seeapp/services/org_selection/search_service.rb).Override
Rails.configuration.x.ror.activeto true for duration ofExternalApis::RorServiceRSpect tests.Rails.configuration.x.ror.active = falseinconfig/initializers/external_apis/ror.rbbreaks many of theExternalApis::RorServiceRSpect tests.