Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vulnerable ws@8.11.0 Dependency by Upgrading karma #841

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

aaronskiba
Copy link
Collaborator

Fixes #840

Changes proposed in this PR:

  • Executed yarn upgrade karma
    • According to the following Dependabot security alert https://github.com/portagenetwork/roadmap/security/dependabot/186, ws needs to be updated to at least ws@8.17.1.
      • However, Dependabot was unable to generate a PR for this fix because karma@6.4.1 requires ws@~8.11.0 via a transitive dependency on socket.io-adapter@2.5.2
      • yarn upgrade karma resolves the dependency on the vulnerable version of ws and also removes it from the project's yarn.lock file.

- This commit is being made to resolve the following Dependabot security alert: https://github.com/portagenetwork/roadmap/security/dependabot/186
Copy link
Collaborator

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronskiba aaronskiba merged commit 44dffb2 into integration Aug 6, 2024
13 checks passed
@aaronskiba aaronskiba deleted the aaron/issues/840 branch August 6, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants