Enable TinyMCE Localisation and Add fr_FR.js Language Pack
#854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`app/assets/javascripts/langs/fr_FR.js` was downloaded from https://www.tiny.cloud/get-tiny/language-packages/
Generated by 🚫 Danger |
lagoan
reviewed
Oct 1, 2024
| @@ -53,6 +53,7 @@ export const defaultOptions = { | |||
| // is not supported, see issue https://github.com/tinymce/tinymce/issues/358 | |||
| skin_url: '/tinymce/skins/oxide', | |||
| content_css: ['/tinymce/tinymce.css'], | |||
| ...(window.i18nLocale === 'fr-CA' && { language: 'fr_FR' }) // handles language switching for DMP Assistant | |||
There was a problem hiding this comment.
What if the window.i18nLocale is set to english but the user sets the language to french ? Sorry if I am missing part of the context here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #703
Changes proposed in this PR:
fr_FR.jsfrom TinyMCE 7 Community Language Packs (https://www.tiny.cloud/get-tiny/language-packages/)language:to TinyMCEdefaultOptionsand have its value always correspond with the language chosen within the app's language selector.