Fix Flaky Tests / Optimize Checking Of plan.title Within spec/features/plans/exports_spec.rb
#871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces `page.source` with (the hopefully more efficient) `page.title` for verifying the page title. Checking the entire page source was potentially causing slowdowns and leading to the intermittent failing of tests within this file.
aaronskiba
changed the title
plan.title Within spec/features/plans/exports_spec.rbplan.title Within spec/features/plans/exports_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #870
Changes proposed in this PR:
spec/features/plans/exports_spec.rb(see Some Selenium/Features Tests Breaking (Independent of Code Changes) #870)expect(page.source).to have_text(plan.title)sometimes failed because sometimespage.source == "".page.source, which returns the entire HTML content of the page, this PR usespage.title, which only returns the contents inside of the<title>tags.page.titledoes not seem to encounter the unwanted behaviour of returning a blank string. Maybe because it is faster (only returning the title should be faster than returning the entire HTML content viapage.source)?<title>title tags and their contents are part of the entire HTML content. So despitepage.sourcereturning a blank string, becausepage.titleis not blank, it follows that the DOM is not blank.