TEST (Do Not Merge) #894
Closed
TEST (Do Not Merge) #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more modifications
Adding some missing methods and start cleanup. We still need to clean up and fix the `openid_connect` method on `omniauth_callbacks_controller.rb`.
When `privileges_changed == true`, the admin_privileges email is triggered. Prior to this commit, the triggered email was working properly with respect to removed privileges. However, in terms of added privileges, it was only being triggered when the API access privilege was added. This commit results in the email now being triggered after any privilege is added.
Fix Triggering and Update Title of Admin Privileges Email
Our app has been using `cookie_store` for some time https://github.com/portagenetwork/roadmap/blob/deployment-portage/config/initializers/session_store.rb. As a result, this rake task is no longer needed. Also, this rake task is currently broken: https://app.rollbar.com/a/ualbertalib/fix/item/dmp_assistant/490
Outside of these two assignments, `@other_organisations` does not exist throughout the codebase.
Addresses the following Bullet warnings: ``` user: aaron GET /users/edit USE eager loading detected Org => [:identifiers] Add to your query: .includes([:identifiers]) Call stack /home/aaron/Documents/GitHub/roadmap/app/services/org_selection/org_to_hash_service.rb:29:in `to_hash' /home/aaron/Documents/GitHub/roadmap/app/presenters/org_selection_presenter.rb:17:in `block in initialize' /home/aaron/Documents/GitHub/roadmap/app/presenters/org_selection_presenter.rb:14:in `map' /home/aaron/Documents/GitHub/roadmap/app/presenters/org_selection_presenter.rb:14:in `initialize' /home/aaron/Documents/GitHub/roadmap/app/views/shared/org_selectors/_local_only.html.erb:11:in `new' /home/aaron/Documents/GitHub/roadmap/app/views/shared/org_selectors/_local_only.html.erb:11:in `_app_views_shared_org_selectors__local_only_html_erb__3013403374084028930_128620' /home/aaron/Documents/GitHub/roadmap/app/views/devise/registrations/_personal_details.html.erb:27:in `block in _app_views_devise_registrations__personal_details_html_erb___1255665928601181115_128580' /home/aaron/Documents/GitHub/roadmap/app/views/devise/registrations/_personal_details.html.erb:1:in `_app_views_devise_registrations__personal_details_html_erb___1255665928601181115_128580' /home/aaron/Documents/GitHub/roadmap/app/views/devise/registrations/edit.html.erb:35:in `_app_views_devise_registrations_edit_html_erb__3040138580235879742_128520' user: aaron GET /users/edit USE eager loading detected Identifier => [:identifier_scheme] Add to your query: .includes([:identifier_scheme]) Call stack /home/aaron/Documents/GitHub/roadmap/app/services/org_selection/org_to_hash_service.rb:30:in `block in to_hash' /home/aaron/Documents/GitHub/roadmap/app/services/org_selection/org_to_hash_service.rb:29:in `to_hash' /home/aaron/Documents/GitHub/roadmap/app/presenters/org_selection_presenter.rb:17:in `block in initialize' /home/aaron/Documents/GitHub/roadmap/app/presenters/org_selection_presenter.rb:14:in `map' /home/aaron/Documents/GitHub/roadmap/app/presenters/org_selection_presenter.rb:14:in `initialize' /home/aaron/Documents/GitHub/roadmap/app/views/shared/org_selectors/_local_only.html.erb:11:in `new' /home/aaron/Documents/GitHub/roadmap/app/views/shared/org_selectors/_local_only.html.erb:11:in `_app_views_shared_org_selectors__local_only_html_erb__3013403374084028930_128620' /home/aaron/Documents/GitHub/roadmap/app/views/devise/registrations/_personal_details.html.erb:27:in `block in _app_views_devise_registrations__personal_details_html_erb___1255665928601181115_128580' /home/aaron/Documents/GitHub/roadmap/app/views/devise/registrations/_personal_details.html.erb:1:in `_app_views_devise_registrations__personal_details_html_erb___1255665928601181115_128580' /home/aaron/Documents/GitHub/roadmap/app/views/devise/registrations/edit.html.erb:35:in `_app_views_devise_registrations_edit_html_erb__3040138580235879742_128520' ```
Optimise Load Time of "Edit Profile" Page
About and Help page changes related to the SSO updates #877
Commit f76758b - "Add link account with CILogon" added the functionality to link an external account via CILogon. However, the commit also removed the functionality to link one's ORCID credentials within the app. This commit adds the ORCID functionality back.
We previously had methods that were dynamically created but are no longer needed since we are creating them specifically. This is done to handle the different workflow for CILogon account creation.
Patch to Put Back ORCID Linking Functionality
Testcases for the Ominiauth controller openid connect
Change was requested here: #888 (comment)
Release `4.1.1+portage-4.2.0` includes a migration and it requires a specific new entry to the `identifier_schemes` table for openid_connect / CILogon to work properly. This rake task is intended to take care of all of that. Note: The changes applied via this rake task have already been executed manually on the staging environment. However, performing the rake task on staging should still have no adverse effects.
…ade-task Add Rake Task For `4.1.1+portage-4.2.0` Upgrade
Adding SSO CILogon
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing updated Ruby Action