Fix for nil user.language_id Bug
#969
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit seeks to resolve issue #154 via a rake task, followed by a migration: 1) rake task - Updates `user.language_id` for all users where `user.language_id == nil` and `user.org.language_id != nil` (`user.org.language_id != nil` should be true for all users) - Updates `user.language_id to `user.org.language_id` for each user. 2) migration - Adds the NOT NULL constraint to the `language_id` column of the `users` table. - Updates `user.language_id` to `Language.default.id` for any remaining nil `user.language_id` values (although, there shouldn't be any).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: By default, migrations are auto-applied within production. However, the rake task needs be executed prior to the migration for the intended
user.language_idupdates to be applied.Fixes #154
Changes proposed in this PR:
This commit seeks to resolve issue Language must exist warning when saving user privilege #154 via a rake task, followed by a migration:
1) rake task
user.language_idfor all users whereuser.language_id == nilanduser.org.language_id != nil(user.org.language_id != nilshould be true for all users)user.language_idtouser.org.language_idfor each of the aforementioned users.2) migration
language_idcolumn of theuserstable.user.language_idtoLanguage.default.idfor any remaining niluser.language_idvalues (although, there shouldn't be any).