Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bool type asyncmsg #2136

Merged

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented May 4, 2024

also notice that if you don't use, then linker will drop it so it wont occupy space

@zxkmm zxkmm marked this pull request as ready for review May 4, 2024 08:31
@zxkmm zxkmm marked this pull request as draft May 5, 2024 03:22
@zxkmm
Copy link
Contributor Author

zxkmm commented May 6, 2024

I have no idea why it can handle bool var but can’t handle the return value of a bool func. Help wanted

@zxkmm zxkmm added the Help Wanted Extra attention is needed label May 6, 2024
@zxkmm
Copy link
Contributor Author

zxkmm commented May 7, 2024

it's a more weird issue and exist on other member func too.
it's caused by memory issue, thanks HTotoo for finding it
let's merge this one and take a deep look later

@zxkmm zxkmm marked this pull request as ready for review May 7, 2024 15:50
@zxkmm zxkmm removed the Help Wanted Extra attention is needed label May 7, 2024
@zxkmm zxkmm requested review from htotoo and gullradriel May 7, 2024 16:02
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go !

@gullradriel gullradriel merged commit 075b23b into portapack-mayhem:next May 8, 2024
3 checks passed
htotoo pushed a commit to htotoo/portapack-mayhem that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants