-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme system #2164
Theme system #2164
Conversation
The important part is theme.hpp, theme.cpp. If I swapped it somewhere there could be missing or unreadable text. (Like black on black, ...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's merge and ask people to test and report if you missed some widgets, else it's an awesome work.
Good job, thanks :-)
After a bit of testing everything looks good to me, at least enough for merging. |
This will add whole system theme options.
While checking, please look for missing or unreadable texts, and report them with screenshots.
Also in the future apps it will be required (if merged) to use colors + styles from the Theme class.