Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix black bg of those bitmap when we have themes enabled #2239

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Sep 7, 2024

I just noticed that the very original screen driver code support transparent for (255,0,255) as transparent color.

The ! Icon for modal originally works, currently working on py script to make other bitmap works.

image
image

@zxkmm
Copy link
Contributor Author

zxkmm commented Sep 7, 2024

mayhem logo would in another PR. it more tricky.
if any of you guys wanna do it, feel free to do so

@zxkmm zxkmm marked this pull request as ready for review September 7, 2024 12:30
@zxkmm zxkmm requested a review from htotoo September 7, 2024 12:31
@zxkmm zxkmm enabled auto-merge (squash) September 7, 2024 12:34
Copy link
Member

@htotoo htotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxkmm zxkmm merged commit 31c844b into portapack-mayhem:next Sep 7, 2024
3 checks passed
@zxkmm zxkmm deleted the bitmap_fix branch September 8, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants