Auto switch C16/C8 default REC format in both BW directions. #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxkmm
approved these changes
Nov 7, 2024
|
sorry have to revert this one because it's lagging the ui, sorry that didn't notice that when testing until opened microphone app |
|
it seems the UI lagging appeared in one of recent change, maybe not this one, lemme check |
|
sorry for false alarm, it's from somewhere else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very Minor issue , (but better for usability ) .
Before that PR, the default REC format change just happended in one direction , when increasing ,
now in both directions (increasing / decreasing ).
1-) default C16 --> C8 REC format change , happens when increasing BW : 1250k ---> 1500k
2-) default C8 --> C16 REC format change , happens when decreasing BW : 1500k ---> 1250k
Cheers,