retry the lock operation only when someone else is holding the lock #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were retrying the lock operation for 5 minutes on all the errors. Create() ends up calling LeaseWithRetries() which has 30 retries with 2 sec sleep. If kvdb is down, the 5 min wait was causing unnecessary delay. Now, we use the 5 minutes timeout only when someone is holding the lock. Signed-off-by: Neelesh Thakur <neelesh.thakur@purestorage.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We were retrying the lock operation for 5 minutes on all the errors. Create()
ends up calling LeaseWithRetries() which has 30 retries with 2 sec sleep.
If kvdb is down, the 5 min wait was causing unnecessary delay. Now, we use
the 5 minutes timeout only when someone is holding the lock.
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: