-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kvdb Debug Log Wrapper #78
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 68.53% 68.32% -0.22%
==========================================
Files 7 7
Lines 3417 3438 +21
==========================================
+ Hits 2342 2349 +7
- Misses 845 860 +15
+ Partials 230 229 -1
Continue to review full report at Codecov.
|
) | ||
|
||
const ( | ||
defaultLogLocation = "/var/lib/osd/kvdb_audit.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this to /var/cores since that's where we are storing all of your support bundles?
return d.kv.Defragment(endpoint, timeout) | ||
} | ||
|
||
func OpenLog(logfile string) (*os.File, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported function. Add function comment
A typical kvdb request debug log will look like this