PWX-30230 : Create all px configmaps in same namespace as portworx #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Bhatia <nbhatia@purestorage.com>
Signed-off-by: Nikita Bhatia <nbhatia@purestorage.com>
Signed-off-by: Nikita Bhatia <nbhatia@purestorage.com>
Signed-off-by: Nikita Bhatia <nbhatia@purestorage.com>
Signed-off-by: Nikita Bhatia <nbhatia@purestorage.com>
nikita-bhatia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://portworx.atlassian.net/browse/PWX-30230
This PR is for migration of namespace from 'kube-system' to 'portworx'. To support this,
Added coreConfigMap struct as wrapper function for existing configmap.
Added Instance() to decide which configmap to use, and handle upgrade scenarios
Logic to update copylock config map entry once upgrade is finished will be handled in porx code.
This PR is to cherrypick changes to 'porx' branch of sched-ops, to update vendor dependency in porx repo.