Add compatibility with Terraform v0.12 and retain v0.11 support #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dghubble
commented
Mar 12, 2019
dghubble
commented
- Upgrade the Terraform SDK to v0.12.0-beta1 to add compatibility with Terraform v0.12.0 (unreleased)
- Retain protocol compatibility with Terraform v0.11
- https://www.terraform.io/upgrade-guides/0-12.html#upgrading-terraform-providers
- Drop support for Go v1.9, Terraform SDK now requires v1.10+
lucab
reviewed
Mar 12, 2019
matchbox/resource_group_test.go
Outdated
| profile = "foo" | ||
| selector { | ||
| qux = "baz" | ||
| profile = "foo" |
There was a problem hiding this comment.
FYI, this re-formatting looks a bit strange.
There was a problem hiding this comment.
Ah, thanks. I should have left well enough alone, its a tabs vs spacing thing. Only thing needed for this PR is preferring the explicit map assignments (which will be required in v0.12)
* Upgrade the Terraform SDK to v0.12.0-beta1 to add compatibility with Terraform v0.12.0 (unreleased) * Retain protocol compatibility with Terraform v0.11 * https://www.terraform.io/upgrade-guides/0-12.html#upgrading-terraform-providers * Drop support for Go v1.9, Terraform SDK now requires v1.10+
dghubble
force-pushed
the
add-terraform-v0.12-support
branch
from
e334dba to
f2c02b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.