Adopt Terraform v0.12 templatefile function #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adopt Terrform v0.12 type and templatefile function features to replace the use of terraform-provider-template's `template_dir` * Use of `for_each` to write local assets requires that consumers use Terraform v0.12.6+ (action required) * Continue use of `template_file` as its quite common. In future, we may replace it as well. * Remove outputs `id` and `content_hash` (no longer used) Background: * `template_dir` was added to `terraform-provider-template` to add support for template directory rendering in CoreOS Tectonic Kubernetes distribution (~2017) * Terraform v0.12 introduced a native `templatefile` function and v0.12.6 introduced native `for_each` support (July 2019) that makes it possible to replace `template_dir` usage
dghubble
deleted the
adopt-terraform-templatefile-instead-of-template_dir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
template_dirfor_eachto write local assets requires that consumers use Terraform v0.12.6+ (action required)template_fileas its quite common. In future, we may replace it as well.idandcontent_hash(no longer used)Background:
template_dirwas added toterraform-provider-templateto add support for template directory rendering in CoreOS Tectonic Kubernetes distribution (~2017)templatefilefunction and v0.12.6 introduced nativefor_eachsupport (July 2019) that makes it possible to replacetemplate_dirusage