Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set kube-apiserver kubelet preferred address types #337

Merged
merged 1 commit into from
Nov 4, 2018

Conversation

dghubble
Copy link
Member

@dghubble dghubble commented Nov 4, 2018

  • Prefer InternalIP and ExternalIP over the node's hostname, to match upstream behavior and kubeadm
  • Previously, hostname-override was used to set node names to internal IP's to work around some cloud providers not resolving hostnames for instances (e.g. DO droplets)

Closes #186

* Prefer InternalIP and ExternalIP over the node's hostname,
to match upstream behavior and kubeadm
* Previously, hostname-override was used to set node names
to internal IP's to work around some cloud providers not
resolving hostnames for instances (e.g. DO droplets)
@dghubble dghubble merged commit 721c847 into master Nov 4, 2018
@dghubble dghubble deleted the kubelet-preferred-address branch November 4, 2018 22:26
@dghubble
Copy link
Member Author

dghubble commented Nov 7, 2018

This causes the Prometheus alert for etcd to break on DigitalOcean clusters.

dghubble added a commit that referenced this pull request Nov 7, 2018
* Kubelet uses a node's hostname as the node name, which isn't
resolvable on DigitalOcean. On DigitalOcean, the node name was
set to the internal IP until #337 switched to instead configuring
kube-apiserver to prefer the InternalIP for communication
* Explicitly configure etcd scrapes to target each controller by
internal IP and port 2381 (replace __address__)
@dghubble
Copy link
Member Author

dghubble commented Nov 7, 2018

Fixed by 7de03a1

sphw pushed a commit to m10io/tokenx-typhoon that referenced this pull request Dec 17, 2018
* Kubelet uses a node's hostname as the node name, which isn't
resolvable on DigitalOcean. On DigitalOcean, the node name was
set to the internal IP until poseidon#337 switched to instead configuring
kube-apiserver to prefer the InternalIP for communication
* Explicitly configure etcd scrapes to target each controller by
internal IP and port 2381 (replace __address__)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant