-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Grafana login information #351
Conversation
The intent is to provide a read-only view dashboard and let it be visible to anyone with network access (i.e. kubectl port-forward or same LAN). (hence no Ingress manifests being provided) I'd like to fully disable logins (in this use case, there is no need at all), but Grafana doesn't have a way to disable the admin user. If you are wanting to manage Grafana directly via accounts (sounds like the case), this is a way but its not a goal. There are upstream Grafana examples more geared for that use case. |
For our case, there's a disable_login_form=true we can add to get example manifests closer to the intended read-only dashboard. Though this just removes the form. I don't get the sense Grafana is fully onboard with "we only configuration via Kubernetes". For your case, correction, this Grafana example isn't suited for managing user accounts. You could currently login to change dashboards, but |
So this is more of a bug report where the addon isn't configured as intended. #352 improves it. |
I don't want to provide public logins; I just want to add more dashboards and the only way to do that after it's deployed is to log in. I understand the read-only intent but the included dashboards are not enough. At the very least it would be nice to have a note on there that disabling logins is an intentional decision and give the user info on where to go if they want a more fully featured Grafana install or want to add more dashboards. Even better would be to split up Given that the NGINX Ingress Controller is a featured addon for Typhoon, I think including the excellent NGINX Ingress controller dashboard in particular would be helpful. If you're interested in making any of these changes, I could submit a pull request for any/all of the above. |
Dashboards can be added by editing the configmaps and reloading if you like. I've been eyeing adding the Nginx dashbords, now that they've worked out some of the bugs. If you're motiviated, you could propose that inline. However, the examples should all be applied via The addons (not just Grafana) may not be exactly to your liking. They're fairly focused/minimal examples that get validated with Typhoon. Feel free to use upstream manifests or your own if you prefer, there's nothing special about the example ones. Or phrased another way, I'm not aiming to differentiate with an ecoystem of addons like the enterprisey distros. They're the same apps at the end of the day. Plus Prometheus, Grafana, etc. docs cover their apps and advanced cases way better than I could hope to. |
Maybe just a very broad one-liner in docs would suffice ("See the Grafana docs to configure Grafana for your use cases"), though it may just be implied |
So simple but I'm embarrassed how long it took me to find the login screen much less the default password!