Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Prometheus addon's node-exporter tolerations #614

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

dghubble
Copy link
Member

@dghubble dghubble commented Jan 7, 2020

  • Change node-exporter DaemonSet tolerations from tolerating all possible NoSchedule taints to tolerating the master taint and the not-ready taint
  • Users who add custom node taints must add their custom taints to the addon node-exporter DaemonSet. As an addon, its expected users copy and manipulate manifests out-of-band in their own systems

@dghubble dghubble force-pushed the reduce-node-exporter-tolerations branch from 7991372 to ab10445 Compare January 7, 2020 05:24
* Change node-exporter DaemonSet tolerations from tolerating
all possible NoSchedule taints to tolerating the master taint
and the not ready taint (we'd like metrics regardless)
* Users who add custom node taints must add their custom taints
to the addon node-exporter DaemonSet. As an addon, its expected
users copy and manipulate manifests out-of-band in their own
systems
@dghubble dghubble force-pushed the reduce-node-exporter-tolerations branch from ab10445 to bb586b6 Compare January 7, 2020 05:24
@dghubble dghubble merged commit bb586b6 into master Jan 7, 2020
@dghubble dghubble deleted the reduce-node-exporter-tolerations branch January 7, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant