Merge pull request #1637 from posit-dev/bugfix/dataviewer/dont_send_r…

…equest small performance tweaks to data viewer scrolling
posit-dev · Oct 19, 2023 · a931f99 · a931f99
2 parents 52ae372 + 5a4c75a
commit a931f99
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/extensions/positron-data-viewer/ui/src/DataPanel.css b/extensions/positron-data-viewer/ui/src/DataPanel.css
@@ -59,6 +59,7 @@ body,
 .container {
 	position: relative;
 	overflow: auto;
+	overflow-anchor: none;
 }
 
 .processing {

diff --git a/extensions/positron-data-viewer/ui/src/DataPanel.tsx b/extensions/positron-data-viewer/ui/src/DataPanel.tsx
@@ -94,8 +94,8 @@ export const DataPanel = (props: DataPanelProps) => {
 		// Overwrite fetchSize so that we never request rows past the end of the dataset
 		fetchSize = Math.min(fetchSize, totalRows - startRow);
 
-		// Let the server know we are requesting more rows
-		if (startRow > 0) {
+		// Request more rows from the server if we don't have them in the cache
+		if (startRow > 0 && !dataModel.renderedRows.includes(startRow)) {
 			vscode.postMessage({
 				msg_type: 'request_rows',
 				start_row: startRow,