Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-adapter: Tail of log files isn't flushed to output channel on exit #707

Closed
lionel- opened this issue Jun 8, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@lionel-
Copy link
Contributor

lionel- commented Jun 8, 2023

To reproduce, start a Jupyter runtime and close it. Compare the runtime log in the output pane to the actual log file (the path should be on the second line in the output after [Positron] Streaming log file:). The output is missing the trailing lines because the logger is shut down before new line events have had time to fire up.

Screenshot 2023-06-08 at 13 18 17
@DavisVaughan
Copy link
Contributor

I see those trailing lines that were previously missing from your output channel now. I also confirmed this contains everything that my kernel.log file had in it!

Screen Shot 2023-06-16 at 8 47 44 AM

@petetronic petetronic added this to the Private Alpha milestone Aug 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants