Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush kernel logs to channel on exit #708

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

lionel-
Copy link
Contributor

@lionel- lionel- commented Jun 8, 2023

Addresses #707.

logTail doesn't seem to have any way to flush the log file so I implemented it manually in the dispose() method.

@lionel- lionel- requested a review from jmcphers June 8, 2023 15:25
Copy link
Collaborator

@jmcphers jmcphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does dispose and disposeLogTail need to be async? (I didn't see any new async calls in the function bodies, but maybe I missed them...)

@lionel-
Copy link
Contributor Author

lionel- commented Jun 8, 2023

Why does dispose and disposeLogTail need to be async? (I didn't see any new async calls in the function bodies, but maybe I missed them...)

The readline iterator over the lines is async, so we iterate over the lines with for await.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants