Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parentheses breaking in pipelines #2677

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Conversation

lionel-
Copy link
Contributor

@lionel- lionel- commented Apr 5, 2024

Addresses #2650

@lionel- lionel- requested a review from DavisVaughan April 5, 2024 14:38
@lionel- lionel- merged commit 7d480eb into main Apr 5, 2024
1 check passed
@lionel- lionel- deleted the bugfix/parentheses-break branch April 5, 2024 15:53
# FIXME
data |>
fn1() |>
# foo"<>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good test, thanks

data |>
fn1() |>
# foo
"<>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this "<>" be placed all the way back at the beginning of the line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh. This will be fixed once I sort out the tabs versus spaces hell in this file

fn1(
x,
y
) |> "<>" fn2()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nstrayer pushed a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants