Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Editor Actions Left / Center / Right menus and EditorActionBarFac… #5815

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

softwarenerd
Copy link
Contributor

Description

This PR adds the EditorActionsLeft (editor/actions/left), EditorActionsCenter (editor/actions/center), and EditorActionsRight (editor/actions/right) menus which are used to create Editor Action Bar actions.

QA Notes

There's nothing new to test yet in this PR. Soon, we will be adding Data Explorer and Quarto actions to the Editor Action Bar.

Copy link

github-actions bot commented Dec 18, 2024

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

petetronic
petetronic previously approved these changes Dec 18, 2024
@petetronic
Copy link
Collaborator

Tested the branch locally and the existing items that were to the right on the new editor action bar still show on the right after this change. I was able to toggle the editor action bar off and on still too.

@softwarenerd softwarenerd merged commit 6c454a0 into main Dec 18, 2024
6 checks passed
@softwarenerd softwarenerd deleted the feature/add-editor-actions-menus branch December 18, 2024 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants