Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Specific starting apps for the editor only view #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gadenbuie
Copy link
Contributor

The app template we use for https://shinylive.io/r/editor currently opens an app with a decent bit of code and comments (compare it with https://shinylive.io/py/editor).

As a heavy user of shinylive.io/r/editor, this adds a decent bit of friction because I need to delete most of the app before I can start working on my example.

This PR modifies the current example flow to add support for a special "Editor" category that, when present, is the starting code for the {appEngine}/editor/ end point. In {appEngine}/examples/ page, the Editor category is filtered out and won't appear in the sidebar.

Copy link
Collaborator

@georgestagg georgestagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

If we wanted to avoid the extra complexity we could also just add your minimal example as the first app, named something like 000-basic. However, this way works OK too.

@gadenbuie gadenbuie mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants