Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow YAML to load hashes and arrays #2477

Closed
wants to merge 1 commit into from
Closed

Allow YAML to load hashes and arrays #2477

wants to merge 1 commit into from

Conversation

catphish
Copy link
Contributor

This aims to resolve #2476

@catphish catphish changed the title fix: Allow YAML to load hashes and arrays. This is required to be able to deserialize webhooks Allow YAML to load hashes and arrays May 24, 2023
@catphish catphish requested a review from adamcooke May 25, 2023 09:32
@adamcooke
Copy link
Contributor

adamcooke commented May 28, 2023 •
edited
Loading

I suspect this might be better solved by ensuring that the data is not serialised as ActiveRecord::HashWithIndifferentAccess to begin with.

I haven't looked in detail at what is being serialised here but I suspect this could have crept in with a Rails upgrade.

@adamcooke adamcooke removed their request for review July 25, 2023 11:55
@ReptoxX ReptoxX mentioned this pull request Nov 22, 2023
Closed
@chrisdeeming chrisdeeming mentioned this pull request Jan 15, 2024
Closed
@catphish
Copy link
Contributor Author

This is being closed because @adamcooke has done a better job of tracking down the issue and will follow with a proper fix.

@catphish catphish closed this Jan 30, 2024
adamcooke added a commit that referenced this pull request Jan 30, 2024
@adamcooke
fix: don't use indifferent access for job params
2bad645 
All jobs refer to parameters using string keys.

closes #2477
closes #2714
closes #2476
closes #2500
@github-actions github-actions bot mentioned this pull request Jan 30, 2024
Merged
@adamcooke adamcooke deleted the yaml-serialize branch February 13, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitali-khangar chaitali-khangar chaitali-khangar approved these changes

@prettyokay-software prettyokay-software prettyokay-software approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to send webhooks because of yaml_column_permitted_classes
4 participants
@catphish @adamcooke @chaitali-khangar @prettyokay-software