Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Allow combined selectors #199

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Allow combined selectors #199

merged 2 commits into from
Mar 7, 2020

Conversation

ryuran
Copy link
Contributor

@ryuran ryuran commented Nov 14, 2019

Fix #198

jonathantneal
jonathantneal suggested changes Nov 16, 2019
View reviewed changes
Copy link
Member

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Great fix. I think we can improve upon it while keeping the code even shorter.

src/lib/get-custom-properties-from-root.js Outdated Show resolved Hide resolved
src/lib/get-custom-properties-from-root.js Outdated Show resolved Hide resolved
@ryuran
Copy link
Contributor Author

ryuran commented Nov 18, 2019

@jonathantneal I change .findIndex() to .some() but I think the .split(',') stay necessary.
.some() return a boolean, so I remove -1 !==

@ryuran ryuran requested a review from jonathantneal November 19, 2019 12:52
@ryuran ryuran force-pushed the fix/combined-selector branch from 3d280e4 to d8dfccc Compare March 5, 2020 13:55
@ryuran
Copy link
Contributor Author

ryuran commented Mar 5, 2020

👆 rebase

@ai
Copy link
Member

ai commented Mar 6, 2020 •
edited
Loading

@Semigradsky can we also release this fix?

The code was shortened after origin review.

@jonathantneal jonathantneal merged commit 24c108b into postcss:master Mar 7, 2020
romainmenke pushed a commit to csstools/postcss-plugins that referenced this pull request Dec 15, 2021
@ryuran @romainmenke
Allow combined selectors (postcss/postcss-custom-properties#199)
896db28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathantneal jonathantneal jonathantneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combined selector with :root
3 participants
@ryuran @ai @jonathantneal