Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Let "warnings" option silence all warnings #67

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

bundyo
Copy link
Contributor

@bundyo bundyo commented Apr 4, 2017

The main reason for this change is that I'm building an Electron app and I don't need fallbacks for my variables.

P.S. If the warnings themselves are not a reason enough, please also consider build logs getting huge and hard to find something in them.

@MoOx
Copy link
Contributor

MoOx commented Apr 4, 2017

So you use code that's not going to work? Electron is supporting custom props already since it's chrome http://caniuse.com/#search=custom%20proper
So why do you use this plugin in the first place?

@bundyo
Copy link
Contributor Author

bundyo commented Apr 5, 2017

Yes, Electron (Chrome) supports custom properties, but it doesn't support the color function, so in order for postcss to compile it, I need to also use postcss-custom-properties (with preserve: "computed"), even if I don't really need it in the renderer. I wonder if postcss can make use of libchromiumcontent to avoid such issues... probably not, but that's not the point of this pull request. :)

@bundyo
Copy link
Contributor Author

bundyo commented Apr 24, 2017

Do we have a decision regarding this issue?

@s-panferov
Copy link

Plz merge this. This is useful when you're using both "real" and "fake" custom properties.

@jonathantneal
Copy link
Member

I use real and fake custom properties, too. This would be very helpful.

@jonathantneal
Copy link
Member

@MoOx, no one is assigned to this. May I assign myself, resolve the conflicts, and merge? There is a need for this, particularly when one must rely on real custom properties.

Here’s my case:

.some-slideout-drawer {
  min-height: 100vh;
  min-height: var(--inner-vh, 100vh);
  width: calc(100vw - 50px);
  width: calc(var(--inner-vw, 100vw) - 50px);
}

Where --inner-vw and --inner-vh are defined as:

function onresize() {
  document.documentElement.style.setProperty('--inner-vw', `${document.documentElement.clientWidth}px`);
  document.documentElement.style.setProperty('--inner-vh', `${document.documentElement.clientHeight}px`);
}

I need this to get around the false vw and vh units in newer iOS Safari and Edge.

@bundyo bundyo force-pushed the make-warnings-work branch from 20458f8 to c371abe Compare June 26, 2017 14:43
@bundyo
Copy link
Contributor Author

bundyo commented Jun 26, 2017

I've updated to latest.

@jonathantneal jonathantneal self-assigned this Jun 26, 2017
@s-panferov
Copy link

s-panferov commented Jun 27, 2017

Our company is really suffering from this. What kind of help can we provide to speed up the merge?

@jonathantneal
Copy link
Member

@s-panferov, I feel your pain. I’m the only person available to look at this right now, and I would like this as well. @ai, do I have the permissions to review, merge, and cut a new release?

Related; I think we need more collaborators, at least for these individual projects.

@ai
Copy link
Member

ai commented Jun 27, 2017

@jonathantneal I have no permission to publish.

Why do you need so many reviews? :) This PR is simple. Release it :)

@jonathantneal jonathantneal merged commit 43b6cbf into postcss:master Jun 27, 2017
@jonathantneal jonathantneal requested review from jonathantneal and removed request for Semigradsky June 27, 2017 18:36
@jonathantneal
Copy link
Member

Tests have passed.

Published as a minor update — 6.1.0 — as this adds functionality in a backwards-compatible manner.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants