Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update #176

Merged
merged 1 commit into from
Feb 25, 2019
Merged

chore(deps): update #176

merged 1 commit into from
Feb 25, 2019

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Feb 20, 2019

fixes #170

Notes:

  • precompile-charcodes is abandoned and don't have compatibility with babel@7, just change charCodeAt on number (keep perf)
  • test with same names are prohibited so i added (2)/(3)/etc
  • snapshots are changes, just update their

@alexander-akait
Copy link
Collaborator Author

No need major release right now, i want to fix:
#173
#174
#175

maybe it is already fixed after updating cssesc, but i want to add tests to avoid future regressions

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 95.383% when pulling 9ee0079 on chore-deps-update into b1da0fa on master.

@jonathantneal jonathantneal merged commit bd00f03 into master Feb 25, 2019
@jonathantneal jonathantneal deleted the chore-deps-update branch February 25, 2019 11:42
@jonathantneal
Copy link
Member

Great work, @evilebottnawi. As far as semver is concerned, is this a patch release?

@alexander-akait
Copy link
Collaborator Author

alexander-akait commented Feb 25, 2019

/cc @jonathantneal
Major after update cssesc, need merge this too https://github.com/postcss/postcss-selector-parser/pulls (one fix)

@jonathantneal
Copy link
Member

All set for the next major (v6.0.0)?

@alexander-akait
Copy link
Collaborator Author

@jonathantneal yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants