Implement Simperby API #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junha1
requested review from
f2koi,
fakedev9999,
hataehyeok,
YoonhoKim0527,
JeongHunP and
just-do-halee
JeongHunP
reviewed
Apr 28, 2023
f2koi
reviewed
Apr 28, 2023
hataehyeok
reviewed
Apr 28, 2023
hataehyeok
reviewed
Apr 28, 2023
f2koi
approved these changes
Apr 29, 2023
fakedev9999
reviewed
Apr 29, 2023
hataehyeok
approved these changes
Apr 29, 2023
fakedev9999
approved these changes
Apr 29, 2023
JeongHunP
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, sorry for this large PR.
This work is co-authored by @JeongHunP so I believe there was basic review on the overall change.
Simperby
The
simperbycrate is the final API for this protocol. There is a working integration test.@lemonholic @JeongHunP @just-do-halee @hataehyeok @TomTaehoonKim @YoonhoKim0527 Please review this
Consensus
I added an integration test for the consensus module @hataehyeok @lemonholic Please review
Network
misc. change has been updated. @YoonhoKim0527 @JeongHunP Please review