Add Member::expelled #454
Merged
Add Member::expelled #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigridjineth
force-pushed
the
feat/#164
branch
3 times, most recently
from
a517290 to
bcc5eee
Compare
JeongHunP
reviewed
Jul 22, 2023
JeongHunP
reviewed
Jul 22, 2023
core/src/verify.rs
Outdated
| @@ -1508,6 +1557,61 @@ mod test { | |||
| .unwrap_err(); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_verify_reserved_state_expelled_member() { | |||
| // Given: Configuration for the test | |||
There was a problem hiding this comment.
I think it might be better to change the format of comments below, for example, just leave a sentence with additional explanation rather than use Given: or When: .
sigridjineth
force-pushed
the
feat/#164
branch
4 times, most recently
from
be32ea9 to
29888e3
Compare
sigridjineth
force-pushed
the
feat/#164
branch
2 times, most recently
from
00be04d to
e5a1ebe
Compare
junha1
approved these changes
Aug 7, 2023
write tests to verify reserved state with expelled members and/or non-expelled members refactor test_push_eligibility to elaborate using Member::expelled add expelled field to Member struct in all of the existing tests Add validation logic for non-mutated delegation state rename Member to member to make it lower cases rewrite comments for test_verify_reserved_state
Remove unnecessary state change check for delegation Change validation login in verify_reserved_state()
Write tests that collects voting power after filtering expelled members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accomplished
Member::expelledin a boolean typereserved_stateinapply_commit()consensus_leader_ordercheck logic with additional conditionssemver::VersionobjectsShout-out to collaborators
@sejongk @yuhatown and @sigridjineth
Issues
This pull request hopes to close #164.