fix: enforce timeouts in the kubenurse http.Server to avoid possible …

…goroutine/memory leaks
postfinance · Jan 21, 2022 · d07df3b · d07df3b
1 parent ebb0764
commit d07df3b
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/internal/kubenurse/server.go b/internal/kubenurse/server.go
@@ -48,12 +48,18 @@ func New(ctx context.Context, k8s kubernetes.Interface) (*Server, error) {
 
 	server := &Server{
 		http: http.Server{
-			Addr:    ":8080",
-			Handler: mux,
+			Addr:              ":8080",
+			Handler:           mux,
+			ReadHeaderTimeout: 5 * time.Second,
+			WriteTimeout:      10 * time.Second,
+			IdleTimeout:       120 * time.Second,
 		},
 		https: http.Server{
-			Addr:    ":8443",
-			Handler: mux,
+			Addr:              ":8443",
+			Handler:           mux,
+			ReadHeaderTimeout: 5 * time.Second,
+			WriteTimeout:      10 * time.Second,
+			IdleTimeout:       120 * time.Second,
 		},
 
 		//nolint:goconst // No need to make "true" a constant in my opinion, readability is better like this.