-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/neighbour limit #120
Merged
Merged
Feat/neighbour limit #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of querying all (valid) neighbouring pods, we filter and only query KUBENURSE_NEIGHBOUR_LIMIT other neighbours. To make sure that all nodes get the right number of queries, we hash each node name, put that in a sorted list (l), and each pod will query the e.g. 10 next nodes in the list, starting from the position given by the node name' hash. i.e. for node named n, we query the 10 next nodes in the list, starting from position l[hash(n)] + 1 cf #55 Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Pull Request Test Coverage Report for Build 8282544160Details
💛 - Coveralls |
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
zbindenren
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe add in a later MR a metric when a node is not getting scaped.
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of querying all (valid) neighbouring pods, we filter and
only query KUBENURSE_NEIGHBOUR_LIMIT other neighbours.
the algorithm is implemented as follows:
neighbourhood_limit
, we pop the max elementthus at the end, the heap contains the 10 next neighbour nodes for our current node