Add additional Helm Configuration options #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use release name instead
domi2120
changed the title
Pull Request Test Coverage Report for Build 2422468185
💛 - Coveralls |
djboris9
approved these changes
Jun 1, 2022
README.md
Outdated
| @@ -23,10 +23,18 @@ The following command can be used to install kubenurse with Helm: `helm upgrade | |||
| | ---------------------------------|---------------------------------------------------------------------------------------------------- | --------------------- | | |||
| | daemonset.image.repository | The repository name | postfinance/kubenurse | | |||
| | daemonset.image.tag | The tag/ version of the image | v1.4.0 | | |||
| | daemonset.podLabels | Additional Labels to be added to the pods of the ademonset | [] | |||
There was a problem hiding this comment.
could you please set Labels lowercase and fix the Daemonset typo?
README.md
Outdated
| @@ -23,10 +23,18 @@ The following command can be used to install kubenurse with Helm: `helm upgrade | |||
| | ---------------------------------|---------------------------------------------------------------------------------------------------- | --------------------- | | |||
| | daemonset.image.repository | The repository name | postfinance/kubenurse | | |||
| | daemonset.image.tag | The tag/ version of the image | v1.4.0 | | |||
| | daemonset.podLabels | Additional Labels to be added to the pods of the ademonset | [] | |||
| | daemonset.podAnnotations | Additional Annotations to be added to the pods of the daemonset | [] | |||
There was a problem hiding this comment.
Could you please set Annotations lowercase?
README.md
Outdated
| | daemonset.podLabels | Additional Labels to be added to the pods of the ademonset | [] | ||
| | daemonset.podAnnotations | Additional Annotations to be added to the pods of the daemonset | [] | ||
| | daemonset.podSecurityContext | The security context of the daemonset | {} | ||
| | daemonset.containerSecurityContext| The Security context of the containers within the pods of the daemonset | {} |
There was a problem hiding this comment.
Could you please set the Security lowercase?
README.md
Outdated
| | namespace | The namespace where kubenurse will be deployed | kube-system | | ||
| | serviceMonitor.enabled | Adds a ServiceMonitor for use with [Prometheus-operator](https://github.com/prometheus-operator/prometheus-operator) | false | ||
| | serviceMonitor.labels | Additional Labels to be added to the ServiceMonitor | {} |
There was a problem hiding this comment.
Could you please set the Labels lowercase?
README.md
Outdated
| | daemonset.podAnnotations | Additional Annotations to be added to the pods of the daemonset | [] | ||
| | daemonset.podSecurityContext | The security context of the daemonset | {} | ||
| | daemonset.containerSecurityContext| The Security context of the containers within the pods of the daemonset | {} | ||
| | daemonset.tolerations | The Tolerations of the daemonset | <code>- effect: NoSchedule </br> key: node-role.kubernetes.io/master</br> operator: Equal </br>- effect: NoSchedule </br> key: node-role.kubernetes.io/control-plane</br> operator: Equal</code> |
There was a problem hiding this comment.
Could you please set the Tolerations lowercase?
|
Hi @domi2120 Thanks for your PR! It looks good to me I've requested only a few minor spelling issues for a more consistent readme document. If you could incorporate these or just make the lower and uppercase more consistent, I would appreciate it. And it also implements the part from #35 (comment) . |
|
Hi @djboris9 |
|
Thanks for your contribution 💯 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase the flexibility of the helm chart, this pull request adds several additional configuration options: