fix(helm): chart should respect -n <namespace>
flag
#53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace should be configured via
-n
helm flag.I kept the
namespace
value invalues.yaml
for backward compatibility reasons. But it would probably be better to set asThen, per default, the
Releases.Namespace
value is taken and you still can overwrite it invalues.yaml
.Currently, if someone wants to install the helm chart, it gets installed in
kube-system
namespace. Even if you specify-n other-namespace
. You have to actively setnamespace: ""
invalues.yaml
to make it installable in a different namespace via helm flags.@djboris9 let me know what you think.
Edit:
Best practices is discussed here. I get the feeling that
namespace: {{ .Releases.Namespace }}
would be best.