Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): new configuration options #57

Merged
merged 1 commit into from
Nov 13, 2022
Merged

feat(helm): new configuration options #57

merged 1 commit into from
Nov 13, 2022

Conversation

zbindenren
Copy link
Member

Revamped Helm Chart

Following changes:

  • remove namespace from values.yaml
  • remove rbac fro values.yaml - installation of clusterrole is done depending on allow_unschedulable
  • labels and label selectors via best practices
  • appVersion updated to 1.7.0
  • all environment variables are configurable via helm values

@zbindenren zbindenren requested a review from djboris9 November 3, 2022 14:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3386410292

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.718%
Totals Coverage Status
Change from base Build 3368223944: 0.0%
Covered Lines: 436
Relevant Lines: 561
💛 - Coveralls

@djboris9
Copy link
Collaborator

lgtm 🔥

@djboris9 djboris9 merged commit 13484e6 into master Nov 13, 2022
@zbindenren zbindenren deleted the new-helm-chart branch December 7, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djboris9 djboris9 Awaiting requested review from djboris9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbindenren @coveralls @djboris9