Final Newman v4 cleanup #1657
Merged
Final Newman v4 cleanup #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codenirvana
commented
Aug 3, 2018
| @@ -88,7 +118,6 @@ describe('cli parser', function () { | |||
| cli('node newman.js run myCollection.json'.split(' '), 'run', | |||
| function (err, opts) { | |||
| expect(err).to.be.null; | |||
| expect(opts.command).to.equal('run'); | |||
There was a problem hiding this comment.
This assertion is not required.
Reference: https://github.com/postmanlabs/newman/pull/1623/files#diff-5ca73ed8232f80fbac6031d2a2c0b8d9L20
codenirvana
commented
Aug 3, 2018
| @@ -75,10 +75,7 @@ module.exports = { | |||
| validProp && (result[key] = value); | |||
|
|
|||
| return result; | |||
| }, { | |||
There was a problem hiding this comment.
These two properties are added unnecessarily.
Reference: https://github.com/postmanlabs/newman/pull/1623/files#diff-024316d2f6b434a9ff0a176917b4ebb3L254
codenirvana
commented
Aug 3, 2018
| @@ -1,4 +1,3 @@ | |||
| module.exports = { | |||
| run: require('./run'), | |||
| version: require('./version') | |||
There was a problem hiding this comment.
Not required because of: https://github.com/postmanlabs/newman/pull/1623/files#diff-024316d2f6b434a9ff0a176917b4ebb3R12
kunagpal
previously approved these changes
Aug 3, 2018
kunagpal
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.