[POA-1519] Allow HTTP response without reason phrase #214
Conversation
Technically, the RFC requires a space even if the reason phrase is empty, but at least one service has been observed to violate this. Add unit tests for both correct and incorrect blank reason phrase, and a one reproducing the original error to verify that Go's http parser is fine with this.
Can you add where we observed this and how you found that this was the case? Empty reason phrase sounds skeptical, since I don't think we would have added any special handling in the Application layer for the service to do this. |
| input: "HTTP/1.1 200\r\n", | ||
| expectedDecision: akinet.Accept, | ||
| }, | ||
| // This is technically legal, as the reason string can be zero bytes long. |
There was a problem hiding this comment.
Or we can just write This is technically legal as reason string is optional for better readability.
There was a problem hiding this comment.
I think it is less clear what "optional" means than the specific thing this test is demonstrating
The TCPdumps demonstrating the problem are in https://postmanlabs.atlassian.net/browse/POA-1519; I didn't want to be more specific about Postman internal services in a public repository. |
Technically, the RFC requires a space even if the reason phrase is empty, but at least one service has been observed to violate this. Add unit tests for both correct and incorrect blank reason phrase, and a one reproducing the original error to verify that Go's http parser is fine with this.