[POA-1513] Add support for different agent install paths in EC2 add #28
Conversation
cmd/internal/ec2/add.go
Outdated
| reportStep(message) | ||
|
|
||
| for _, path := range agentInstallPaths { | ||
| if _, err := exec.LookPath(path); err == nil { |
There was a problem hiding this comment.
I wonder whether we should be using LookPath directly, for just "postman-insights-agent", and using whichever is first in the path? Failing that, maybe use argv[0]?
I don't think there's anything necessarily wrong with building in the set of paths that we know the install script uses today, but it does mean that the two have to be kept in sync. So that's why I'm wondering whether we could be more flexible in terms of "wherever in the path postman-insights-agent" is installed or "wherever you successfully ran the agent" -- the latter seems very reasonable to me if we can make it work?
There was a problem hiding this comment.
I have added a check for the default agent path also.
cmd/internal/ec2/add.go
Outdated
| } | ||
|
|
||
| envFile, err := os.Create(envFilePath) | ||
| err = util.GenrateAndWriteTemplateFile(envFileFS, envFileTemplateName, envFileBasePath, envFileName, envFiledata) |
There was a problem hiding this comment.
Typo
| err = util.GenrateAndWriteTemplateFile(envFileFS, envFileTemplateName, envFileBasePath, envFileName, envFiledata) | |
| err = util.GenerateAndWriteTemplateFile(envFileFS, envFileTemplateName, envFileBasePath, envFileName, envFiledata) |
In this PR, we have changed the
ec2 setupcommand to check for the agent install path before setting it in the postman-insight-agent systemd file.Changes done:
postman-insights-agent.servicefile