Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POA-2003] Set obfuscation enum in witness method meta #36

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

mudit-postman
Copy link
Contributor

@mudit-postman mudit-postman commented Oct 8, 2024

  • In this PR, we have added support to identify whether a witness payload is obfuscated or not.
  • We are setting the Obfuscation attribute to ZERO_VALUE in the obfuscation() function and NONE in the else branch in the queueUpload() function in backend_collection.go.
    • ZERO_VALUE assignment is still kept to update the value if the witness is obfuscated later in report_buffer.go due to the large size
  • Also updated the observability-ir version.

@mudit-postman mudit-postman requested a review from mgritter October 8, 2024 08:56
trace/obfuscate.go Show resolved Hide resolved
@liujed
Copy link
Member

liujed commented Oct 8, 2024

* We are setting `Obfuscation` attribute to `ZERO_VALUE` in `obfuscation()` function. The default enum value is `NONE`

Please see postmanlabs/observability-ir#15 (comment).

@mudit-postman mudit-postman requested a review from liujed October 8, 2024 15:57
go.mod Outdated Show resolved Hide resolved
trace/backend_collector.go Outdated Show resolved Hide resolved
@mudit-postman mudit-postman merged commit 21d6d02 into main Oct 8, 2024
4 checks passed
@mudit-postman mudit-postman deleted the mudit/POA-2003 branch October 8, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants