Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POA-2004] Don't capture payloads of success requests #37

Merged
merged 6 commits into from
Oct 8, 2024
Merged

[POA-2004] Don't capture payloads of success requests #37

merged 6 commits into from
Oct 8, 2024

Conversation

mudit-postman
Copy link
Contributor

@mudit-postman mudit-postman commented Oct 8, 2024 •
edited
Loading

  • Add support to obfuscate success (2xx or 3xx) responses always if the sendWitnessPayloads is enabled
  • Add a hasErrorResponses() util function, which will check the response object of the method and return false if the response code is less than 400.

@mudit-postman mudit-postman requested a review from mgritter October 8, 2024 10:01
@mudit-postman mudit-postman requested a review from liujed October 8, 2024 17:13
liujed
liujed approved these changes Oct 8, 2024
View reviewed changes
trace/util.go Outdated Show resolved Hide resolved
liujed
liujed reviewed Oct 8, 2024
View reviewed changes
trace/util.go Outdated Show resolved Hide resolved
@mudit-postman mudit-postman merged commit e0efdf9 into main Oct 8, 2024
4 checks passed
@mudit-postman mudit-postman deleted the mudit/POA-2004 branch October 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liujed liujed liujed approved these changes

@mgritter mgritter Awaiting requested review from mgritter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mudit-postman @liujed