Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POA-1908][POA-1912] Add warning message for experimental flags #46

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[POA-1908][POA-1912] Add warning message for experimental flags #46

merged 1 commit into from
Nov 8, 2024

Conversation

mudit-postman
Copy link
Contributor

  • Add a new PrintFlagsWarning() util function to print BIG warning message for experimental flags
  • Used this function in root.go as a preRun task
  • For now we have added only 2 flags.

@mudit-postman
Copy link
Contributor Author

@liujed, do we need to add other flags also in the list?

@mudit-postman mudit-postman requested a review from liujed November 7, 2024 11:52
@mudit-postman mudit-postman merged commit cbb0a2a into main Nov 8, 2024
4 checks passed
@mudit-postman mudit-postman deleted the mudit/POA-1908-1912 branch November 8, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liujed liujed liujed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mudit-postman @liujed