Fixed an issue where mergeAndValidate() threw error for files not in UTF-8 encoding. #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VShingala
changed the title
VShingala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where mergeAndValidate() API throw error for any files in input that contains data not in UTF-8 encoding. Since, for folder import, files can be in such format often time the conversion ended in error.
Issue was with the
fast-xml-parsermodule. It throws error while parsing files that are not in UTF-8 format. With this PR, we'll ignore such errors and simply report content of such file as empty string for safeParseToObject() function.We've also added corresponding tests to make sure intended functionality works as expected.