Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document why not having shims is good #433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grosser
Copy link

@grosser grosser commented Feb 27, 2020

I came here from rbenv/rbenv#1223 :trollface:

@peterb
Copy link

peterb commented Apr 20, 2020

❤️

@postmodern
Copy link
Owner

Decided to mention in 29af09c and 4f38caa about when shims require constant regeneration, which is an annoying chore. I feel like rbenv could just optimize the shim regeneration or background the process and declare the problem solved.

@eregon
Copy link
Contributor

eregon commented Feb 3, 2021

Those commits don't mention the performance cost of shims though, so it seems a separate concern.
👍 for this PR.

@peterb
Copy link

peterb commented Feb 3, 2021

Had another look at this and I've changed my mind.

@postmodern I think the time it takes for the shim to execute is dependent on the system architecture and might involve binaries? If I'm right, then it feels to me like this is something that would be better off treated as an add-on, maybe by providing a hook for plug-ins.

@eregon It would be nice to include some real-world figures in the docs, but surely that would have to mention the system specifications? The laws of nature and mathematics would tell us that a single number isn't statistically meaningful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants