Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend setup.sh as the default installation method. #475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ragaskar
Copy link

@ragaskar ragaskar commented Mar 4, 2022

This would've saved me a few minutes of wondering why chruby was "command not found" after compiling it on my system. 😄

I mean, my fault for not fully reading the instructions, but I suspect that's how many of us operate. 😄

EDIT: Oops, also wanted to take a moment to say a big "THANK YOU" for chruby. I have used it often over the years.

This would've saved me a few minutes of wondering why `chruby` was "command not found" after compiling it on my system. 😄 

I mean, my fault for not fully reading the instructions, but I suspect that's how many of us operate. 😄
@postmodern
Copy link
Owner

The reason why make install does not also install configuration is I don't want to choose for the user how chruby is configured/loaded. Users can choose whether chruby is loaded via /etc/profile.d/ or in ~/.bashrc/~/.zshrc.

@ragaskar
Copy link
Author

ragaskar commented Mar 5, 2022

Yes, that makes sense to me. Sorry if the PR wording is unclear: I'm proposing a change that would guide most users towards running setup.sh vs running make install. I suspect folks who want to customize how chruby is installed will read the whole doc, whereas users who just want a chruby asap would be better served by just running the ./setup.sh script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants