Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base class 'flash-message' to flash component #210

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Add base class 'flash-message' to flash component #210

merged 1 commit into from
Sep 28, 2017

Conversation

jfelchner
Copy link
Contributor

Closes #133

@sbatson5
Copy link
Collaborator

sbatson5 commented Oct 18, 2016 •
edited
Loading

@jfelchner Thoughts on adding a quick integration test to assert that the class is present?

Let me know if you have questions on how to test this and I'd be happy to write something up.

@sbatson5
Copy link
Collaborator

going to merge this and add an integration test as a separate PR.

@sbatson5 sbatson5 merged commit 5fd8503 into adopted-ember-addons:master Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfelchner @sbatson5