Fix issue with duplicate points #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into an issue with a point cloud, where PotreeConvert would become stuck in the indexing phase at 100%. Basically, the symptoms are identical to issue #489.
After some debugging, it got clear that potree detected many duplicate points in the file and was trying to deduplicate them. This calls the
contains(map, key)helper for every single point in the current split. This helper takes the map of distinct points by value. Having to copy the map once for every point in the current split takes so long, that it seems like PotreeConvert runs 'forever'.After changing the signature of
contains(map, key)so that it takes its parameters by reference, the problem is gone.