-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add override so serialiser saves hasMany #111
Add override so serialiser saves hasMany #111
Conversation
@@ -0,0 +1,3 @@ | |||
import { Serializer } from 'ember-pouch/index'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need index:
import { Serializer } from 'ember-pouch';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks. I emulated this line. Changed now.
The failing test is related to the change:
I don't know if it's a bug in ember-data 1.13. |
575459f
to
ff1643c
Compare
@fsmanuel, I was able to get the tests passing on Ember 1.13 by adding this override of
If the Ember Data implementation of |
@backspace LGTM! |
ff1643c
to
8630e55
Compare
Seems to be failing only in Ember Data 1.13:
Do we want to drop support for 1.13 or is this fixable? |
@nolanlawson: I just pushed that override for |
LGTM! Thanks for the fix; passing in Travis now. |
As suggested here by @fsmanuel.
What I missed in my previous pull request was that the dummy application wasn’t using the PouchDB serialiser!