Fixed: added semicolon at the end of the file

[pavelivanov]

Crash concatenate js files

[nolanlawson]

This dist file is actually auto-generated, so it's browserify that decided not to put a ; at the end...

[mmrko]

I came across this issue as well a while back. It did take some time to track it down. Bumping browserify to 5.0.0 would fix the semicolon issue but also require changes to the build. If I find the time at some point I can look into this better. For now, I'm just using the minified version. Changing bower.json to point to the minified version could save people from the possible headache. Thanks for the awesome plugin btw! :)

[nolanlawson]

What concatenators out there aren't adding \n or ; between files? I've got lots of plugins using this version of Browserify, so I'm loathe to go out and fix them all. >_<

[mmrko]

Well, this is definitely somewhat of an edge case. I'm using gulp-useref, which in turn uses gulp-concat that passes \n as the separator for concat-with-sourcemaps. In some scenarios a newline doesn't however guard against the missing semicolon issue.

[nolanlawson]

TBH I'm of the opinion that this is a bug in gulp-concat. Much easier to fix it in one build tool, as opposed to fixing it in every JS lib on the planet. :)

Sorry to be a bit stubborn, but I'm gonna close this one.

[nolanlawson]

I filed an issue on gulp-concat ^

[mmrko]

Yup, I agree :)