Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support running with NodeJS #176

Merged
merged 5 commits into from
Nov 20, 2017
Merged

Conversation

ptitjes
Copy link
Collaborator

@ptitjes ptitjes commented Nov 12, 2017

This PR has for goal to support running pouchdb-authentication with NodeJS.

It requires pouchdb/pouchdb#6814 to be fixed (see PR pouchdb/pouchdb#6815) and also a tiny fix needed to resolve #127, #130, and #141 (in the line of fredericgermain@fc3d6c1 but keeping the 'Content-Type' header).

@ptitjes ptitjes changed the title enhance test infrastructure to also test with nodejs support running with NodeJS Nov 12, 2017
@ptitjes
Copy link
Collaborator Author

ptitjes commented Nov 12, 2017

Blocked by pouchdb/pouchdb#6814.

The only remaining work is to get the corresponding PR in pouchdb accepted (pouchdb/pouchdb#6815).

@ptitjes ptitjes force-pushed the support-nodejs branch 2 times, most recently from f8ac9b3 to 421c691 Compare November 14, 2017 17:31
@ptitjes ptitjes requested a review from tlvince November 15, 2017 11:05
@ptitjes ptitjes force-pushed the support-nodejs branch 8 times, most recently from 247d48c to 52dd8f5 Compare November 20, 2017 05:26
@ptitjes
Copy link
Collaborator Author

ptitjes commented Nov 20, 2017

Tests on node and ie11 have been allowed failure so merging and waiting for upstream to be bumped.

@ptitjes ptitjes merged commit 79aaec5 into pouchdb-community:master Nov 20, 2017
@ptitjes ptitjes deleted the support-nodejs branch December 22, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db.login() Not Working as Intended
1 participant