Update process user input #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Figured I'd just start the PR so you could see the diff. |
…963/tcping into update_process_user_input
pouriyajamshidi
force-pushed
the
update_process_user_input
branch
from
53ff9cf to
1068f3f
Compare
pouriyajamshidi
requested changes
Sep 16, 2023
There was a problem hiding this comment.
Hey @friday963,
Thanks for your contribution. It definitely looks much cleaner than before.
After my requested changes are in place, this can get merged in.
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Please provide the requested parameters below to help us review your pull request.
Pull requests without a body or explanation will be rejected.
Refactor updateuserinput func to consolidate logic and args setttings into smaller units of work.
Issue ticket number and link
Closes #
Checklist before requesting a review
make checkand there are no failures.Type of change
Please delete options that are not relevant.
N/A